Fix duplicate wallet creation in non-persistent path#233
Merged
tvpeter merged 1 commit intobitcoindevkit:masterfrom Jan 5, 2026
Merged
Fix duplicate wallet creation in non-persistent path#233tvpeter merged 1 commit intobitcoindevkit:masterfrom
tvpeter merged 1 commit intobitcoindevkit:masterfrom
Conversation
110CodingP
approved these changes
Jan 2, 2026
Pull Request Test Coverage Report for Build 20714192688Details
💛 - Coveralls |
Collaborator
|
@Mshehu5, please sign your commits so the PR can be merged. |
The non-persistent wallet path (when sqlite/redb features are disabled) was creating the wallet twice: first as immutable to create the blockchain_client, then again as mutable. This caused the blockchain_client to be initialized with the first wallet instance, but then used with the second wallet instance, creating a mismatch.
Contributor
Author
just signed it now |
tvpeter
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The non-persistent wallet path (when sqlite/redb features are disabled) was creating the wallet twice: first as immutable to create the blockchain_client, then again as mutable. This caused the blockchain_client to be initialized with the first wallet instance, but then used with the second wallet instance, creating a mismatch.
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
The PR addresses Duplicate wallet creation in non-persistent path #232